paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 16:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

reactions: Correctly convert template output to a jQuery object.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2025-05-08 16:33:47 -07:00
committed by Tim Abbott
parent 2320a8917e
commit 147a2c40b2
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/reactions.ts
View File

@@ -394,7 +394,7 @@ export let insert_new_reaction = (
message_reactions: [context], message_reactions: [context],
}, },
}; };
const $msg_reaction_section = render_message_reactions(reaction_section_context); const $msg_reaction_section = $(render_message_reactions(reaction_section_context));
$rows.find(".messagebox-content").append($msg_reaction_section); $rows.find(".messagebox-content").append($msg_reaction_section);
} else { } else {
const $new_reaction = $(render_message_reaction(context)); const $new_reaction = $(render_message_reaction(context));

4
web/tests/reactions.test.cjs
View File

@@ -890,8 +890,8 @@ test("insert_new_reaction (first reaction)", ({mock_template, override_rewire})
$rows.set_find_results(".messagebox-content", $messagebox_content); $rows.set_find_results(".messagebox-content", $messagebox_content);
let append_called = false; let append_called = false;
$messagebox_content.append = (element) => { $messagebox_content.append = ($element) => {
assert.equal(element, "<msg-reactions-section-stub>"); assert.equal($element.selector, "<msg-reactions-section-stub>");
append_called = true; append_called = true;
}; };