paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

hotkey: Update deprecation notices to use Shift for capital letters.

Browse Source 
To make the deprecation notices consistent with how we format shortcut
keys, we use "Shift +" prefix for capital letters, and write small
letters as capitals.
This commit is contained in:
N-Shar-ma
2023-03-09 02:19:08 +05:30
committed by Tim Abbott
parent c6ba33b7b4
commit 1480eca7d5
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/deprecated_feature_notice.js
View File

@@ -20,11 +20,11 @@ export function maybe_show_deprecation_notice(key) {
let message; let message;
const isCmdOrCtrl = common.has_mac_keyboard() ? "Cmd" : "Ctrl"; const isCmdOrCtrl = common.has_mac_keyboard() ? "Cmd" : "Ctrl";
switch (key) { switch (key) {
case "C": case "Shift + C":
message = get_hotkey_deprecation_notice("C", "x"); message = get_hotkey_deprecation_notice("Shift + C", "X");
break; break;
case "*": case "*":
message = get_hotkey_deprecation_notice("*", isCmdOrCtrl + " + s"); message = get_hotkey_deprecation_notice("*", isCmdOrCtrl + " + S");
break; break;
case "Shift + S": case "Shift + S":
message = get_hotkey_deprecation_notice("Shift + S", "S"); message = get_hotkey_deprecation_notice("Shift + S", "S");

2
web/src/hotkey.js
View File

@@ -881,7 +881,7 @@ export function process_hotkey(e, hotkey) {
browser_history.go_to_location("drafts"); browser_history.go_to_location("drafts");
return true; return true;
case "C_deprecated": case "C_deprecated":
deprecated_feature_notice.maybe_show_deprecation_notice("C"); deprecated_feature_notice.maybe_show_deprecation_notice("Shift + C");
return true; return true;
case "star_deprecated": case "star_deprecated":
deprecated_feature_notice.maybe_show_deprecation_notice("*"); deprecated_feature_notice.maybe_show_deprecation_notice("*");