paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 08:33:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

composebox_typeahead: Improve insertion of link syntax.

Browse Source 
We do not need to extract the stream name from typed text as we have
it available in the TopicSuggestion.
This commit is contained in:
Kislay Verma
2025-02-23 20:52:15 +05:30
committed by Tim Abbott
parent 676fbb6d99
commit 1500ba4211
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
web/src/composebox_typeahead.ts
View File

@@ -1227,20 +1227,18 @@ export function content_typeahead_selected(
// "beginning" contains all the text before the cursor, so we use lastIndexOf to // "beginning" contains all the text before the cursor, so we use lastIndexOf to
// avoid any other stream+topic mentions in the message. // avoid any other stream+topic mentions in the message.
const syntax_start_index = beginning.lastIndexOf("#**"); const syntax_start_index = beginning.lastIndexOf("#**");
// Get the stream name, not including "#**" at the start or ">" at the end.
const topic_start_index = beginning.lastIndexOf(">");
const stream_name = beginning.slice(syntax_start_index + 3, topic_start_index);
let replacement_text;
if (item.is_channel_link) { if (item.is_channel_link) {
// The user opted to select only the stream and not specify a topic. // The user opted to select only the stream and not specify a topic.
beginning = beginning.slice(0, syntax_start_index); replacement_text = topic_link_util.get_stream_link_syntax(item.stream_data.name);
beginning += topic_link_util.get_stream_link_syntax(stream_name) + " "; } else {
break; replacement_text = topic_link_util.get_stream_topic_link_syntax(
item.stream_data.name,
item.topic,
);
} }
beginning = beginning = beginning.slice(0, syntax_start_index) + replacement_text + " ";
beginning.slice(0, syntax_start_index) +
topic_link_util.get_stream_topic_link_syntax(stream_name, item.topic) +
" ";
break; break;
} }
case "time_jump": { case "time_jump": {