paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

tooltips: Convert recipient row tooltips to tippy.

Browse Source
This commit is contained in:
Hardik Dharmani
2023-04-28 17:40:07 +05:30
committed by Tim Abbott
parent 95c81ba029
commit 15860c8b13
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/e2e-tests/compose.test.ts
View File

@@ -113,7 +113,7 @@ async function test_open_close_compose_box(page: Page): Promise<void> {
async function test_narrow_to_private_messages_with_cordelia(page: Page): Promise<void> { async function test_narrow_to_private_messages_with_cordelia(page: Page): Promise<void> {
const you_and_cordelia_selector = const you_and_cordelia_selector =
'*[title="Narrow to your direct messages with Cordelia, Lear\'s daughter"]'; '*[data-tippy-content="Narrow to your direct messages with Cordelia, Lear\'s daughter"]';
// For some unknown reason page.click() isn't working here. // For some unknown reason page.click() isn't working here.
await page.evaluate( await page.evaluate(
(selector: string) => document.querySelector<HTMLElement>(selector)!.click(), (selector: string) => document.querySelector<HTMLElement>(selector)!.click(),

12
web/templates/recipient_row.hbs
View File

@@ -2,9 +2,9 @@
<div class="message_header message_header_stream right_part" data-stream-id="{{stream_id}}"> <div class="message_header message_header_stream right_part" data-stream-id="{{stream_id}}">
<div class="message-header-contents" style="background: {{recipient_bar_color}};"> <div class="message-header-contents" style="background: {{recipient_bar_color}};">
{{! stream link }} {{! stream link }}
<a class="message_label_clickable narrows_by_recipient stream_label" <a class="message_label_clickable narrows_by_recipient stream_label tippy-zulip-delayed-tooltip"
href="{{stream_url}}" href="{{stream_url}}"
title="{{t 'Narrow to stream "{display_recipient}"' }}"> data-tippy-content="{{t 'Narrow to stream "{display_recipient}"' }}">
<span class="stream-privacy-modified-color-{{stream_id}} stream-privacy filter-icon" style="color: {{stream_privacy_icon_color}}"> <span class="stream-privacy-modified-color-{{stream_id}} stream-privacy filter-icon" style="color: {{stream_privacy_icon_color}}">
{{> stream_privacy}} {{> stream_privacy}}
</span> </span>
@@ -20,9 +20,9 @@
{{! topic stuff }} {{! topic stuff }}
<span class="stream_topic"> <span class="stream_topic">
{{! topic link }} {{! topic link }}
<a class="message_label_clickable narrows_by_topic" <a class="message_label_clickable narrows_by_topic tippy-zulip-delayed-tooltip"
href="{{topic_url}}" href="{{topic_url}}"
title="{{t 'Narrow to stream "{display_recipient}", topic "{topic}"' }}"> data-tippy-content="{{t 'Narrow to stream "{display_recipient}", topic "{topic}"' }}">
{{#if use_match_properties}} {{#if use_match_properties}}
{{{match_topic}}} {{{match_topic}}}
{{else}} {{else}}
@@ -80,9 +80,9 @@
{{else}} {{else}}
<div class="message_header message_header_private_message"> <div class="message_header message_header_private_message">
<div class="message-header-contents"> <div class="message-header-contents">
<a class="message_label_clickable narrows_by_recipient stream_label" <a class="message_label_clickable narrows_by_recipient stream_label tippy-zulip-delayed-tooltip"
href="{{pm_with_url}}" href="{{pm_with_url}}"
title="{{t 'Narrow to your direct messages with {display_reply_to}' }}"> data-tippy-content="{{t 'Narrow to your direct messages with {display_reply_to}' }}">
<span class="private_message_header_icon"><i class="zulip-icon zulip-icon-user"></i></span> <span class="private_message_header_icon"><i class="zulip-icon zulip-icon-user"></i></span>
{{t "You and {display_reply_to}" }} {{t "You and {display_reply_to}" }}
</a> </a>