paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Remove "subject" from stream_topic.py.

Browse Source
This commit is contained in:
Steve Howell
2018-12-23 17:45:18 +00:00
committed by Tim Abbott
parent d3139266c8
commit 16328732d4
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/linter_lib/custom_check.py
View File

@@ -37,11 +37,6 @@ FILES_WITH_LEGACY_SUBJECT = {
# These are tied more to our API than our DB model. # These are tied more to our API than our DB model.
'zerver/lib/api_test_helpers.py', 'zerver/lib/api_test_helpers.py',
# TRY TO FIX THESE! If you can't fix them, try to
# add comments here and/or in the file itself about
# why sweeping subject is tricky.
'zerver/lib/stream_topic.py',
# This has lots of query data embedded, so it's hard # This has lots of query data embedded, so it's hard
# to fix everything until we migrate the DB to "topic". # to fix everything until we migrate the DB to "topic".
'zerver/tests/test_narrow.py', 'zerver/tests/test_narrow.py',

4
zerver/lib/stream_topic.py
View File

@@ -13,8 +13,8 @@ class StreamTopicTarget:
''' '''
This class is designed to help us move to a This class is designed to help us move to a
StreamTopic table or something similar. It isolates StreamTopic table or something similar. It isolates
places where we are are still using `subject` or places where we are are still using `topic_name` as
`topic_name` as a key into tables. a key into tables.
''' '''
def __init__(self, stream_id: int, topic_name: str) -> None: def __init__(self, stream_id: int, topic_name: str) -> None:
self.stream_id = stream_id self.stream_id = stream_id