paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 04:23:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

auth: Fix up AzureAD Oauth2 docs and config.

Browse Source 
This commit brings AzureAD config in line with other backends:
- SOCIAL_AUTH_AZUREAD_OAUTH2_SECRET gets fetched in computed_settings.py
  instead of default_settings, consistent with github/gitlab/etc.
- SOCIAL_AUTH_AZUREAD_OAUTH2_KEY gets fetched in default_settings via
  get_secret(..., development_only=True) like other social backends, to
  allow easier set up in dev environment, in the dev-secrets.conf file.
- The secret gets renamed from azure_oauth2_secret to
  social_auth_azuread_oauth2_secret to have a consistent naming scheme with
  other social backends and with the SOCIAL_AUTH_AZUREAD_OAUTH2_KEY
  name. This is backwards-incompatible.

The instructions for setting it up are updated to fit how this is
currently done in AzureAD.
This commit is contained in:
Mateusz Mandera
2022-09-05 13:30:17 +02:00
committed by Tim Abbott
parent 3826fc8af9
commit 16829bd84b
4 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/overview/changelog.md
View File

@@ -96,7 +96,11 @@ log][commit-log] for an up-to-date list of raw changes.
#### Upgrade notes for 6.0
- None yet.
- Installations using the AzureAD authentication backend will need to
update `/etc/zulip/zulip-secrets.conf` after upgrading. The
`azure_oauth2_secret` secret was renamed to
`social_auth_azuread_oauth2_secret`, to match our other external
authentication methods.
## Zulip 5.x series