paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui: Fix loading spinner glitch.

Browse Source 
On calling `loading.make_indicator` for the second
time or more no spinner is being displayed.

This bug can be viewed on visiting a `near: 1` narrow
and the spinner for the newer messages is displayed
only once (i.e. the first time it is rendered), while
the logo is displayed every time.

This happens because `loading.destroy_indicator` sets
the css of that container to display: "none". This can
be removed as we are emptying the container just above.

Introduced in 953d475274.
This commit is contained in:
Ryan Rehman
2020-07-19 10:52:40 +05:30
committed by Tim Abbott
parent 619f11a0ce
commit 1696c9ac20
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/loading.js
View File

@@ -59,7 +59,7 @@ exports.destroy_indicator = function (container) {
} }
container.removeData("spinner_obj"); container.removeData("spinner_obj");
container.empty(); container.empty();
container.css({width: 0, height: 0, display: "none"}); container.css({width: 0, height: 0});
}; };
window.loading = exports; window.loading = exports;