paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 03:41:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use sub_store for get/validation.

Browse Source 
This reduces the complexity of our dependency graph.

It also makes sub_store.get parallel to message_store.get.
For both you pass in the relevant id to get the
full validated object.
This commit is contained in:
Steve Howell
2021-04-15 15:02:54 +00:00
committed by Tim Abbott
parent d2bbb7d521
commit 173ce9a3fc
26 changed files with 90 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/peer_data.js
View File

@@ -1,7 +1,7 @@
import * as blueslip from "./blueslip";
import {LazySet} from "./lazy_set";
import * as people from "./people";
import * as stream_data from "./stream_data";
import * as sub_store from "./sub_store";
// This maps a stream_id to a LazySet of user_ids who are subscribed.
const stream_subscribers = new Map();
@@ -21,7 +21,7 @@ function get_user_set(stream_id) {
// We create one on the fly as necessary, but we warn in that case.
assert_number(stream_id);
if (!stream_data.get_sub_by_id(stream_id)) {
if (!sub_store.get(stream_id)) {
blueslip.warn("We called get_user_set for an untracked stream: " + stream_id);
}