paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 08:56:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use sub_store for get/validation.

Browse Source 
This reduces the complexity of our dependency graph.

It also makes sub_store.get parallel to message_store.get.
For both you pass in the relevant id to get the
full validated object.
This commit is contained in:
Steve Howell
2021-04-15 15:02:54 +00:00
committed by Tim Abbott
parent d2bbb7d521
commit 173ce9a3fc
26 changed files with 90 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/stream_edit.js
View File

@@ -29,6 +29,7 @@ import * as stream_data from "./stream_data";
import * as stream_pill from "./stream_pill";
import * as stream_settings_data from "./stream_settings_data";
import * as stream_ui_updates from "./stream_ui_updates";
import * as sub_store from "./sub_store";
import * as subs from "./subs";
import * as ui from "./ui";
import * as ui_report from "./ui_report";
@@ -162,7 +163,7 @@ function get_sub_for_target(target) {
return undefined;
}
const sub = stream_data.get_sub_by_id(stream_id);
const sub = sub_store.get(stream_id);
if (!sub) {
blueslip.error("get_sub_for_target() failed id lookup: " + stream_id);
return undefined;
@@ -443,7 +444,7 @@ export function stream_settings(sub) {
export function show_settings_for(node) {
const stream_id = get_stream_id(node);
const slim_sub = stream_data.get_sub_by_id(stream_id);
const slim_sub = sub_store.get(stream_id);
stream_data.clean_up_description(slim_sub);
const sub = stream_settings_data.get_sub_for_settings(slim_sub);
@@ -542,7 +543,7 @@ function change_stream_privacy(e) {
e.stopPropagation();
const stream_id = $(e.target).data("stream-id");
const sub = stream_data.get_sub_by_id(stream_id);
const sub = sub_store.get(stream_id);
const data = {};
const stream_privacy_status = $(".stream-privacy-status");
stream_privacy_status.hide();
@@ -735,7 +736,7 @@ export function initialize() {
$("#subscriptions_table").on("click", ".change-stream-privacy", (e) => {
const stream_id = get_stream_id(e.target);
const stream = stream_data.get_sub_by_id(stream_id);
const stream = sub_store.get(stream_id);
const template_data = {
stream_id,