paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 20:13:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use sub_store for get/validation.

Browse Source 
This reduces the complexity of our dependency graph.

It also makes sub_store.get parallel to message_store.get.
For both you pass in the relevant id to get the
full validated object.
This commit is contained in:
Steve Howell
2021-04-15 15:02:54 +00:00
committed by Tim Abbott
parent d2bbb7d521
commit 173ce9a3fc
26 changed files with 90 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/stream_events.js
View File

@@ -15,6 +15,7 @@ import * as stream_color from "./stream_color";
import * as stream_data from "./stream_data";
import * as stream_list from "./stream_list";
import * as stream_muting from "./stream_muting";
import * as sub_store from "./sub_store";
import * as subs from "./subs";
// In theory, this function should apply the account-level defaults,
@@ -28,7 +29,7 @@ function update_stream_setting(sub, value, setting) {
}
export function update_property(stream_id, property, value, other_values) {
const sub = stream_data.get_sub_by_id(stream_id);
const sub = sub_store.get(stream_id);
if (sub === undefined) {
// This isn't a stream we know about, so ignore it.
blueslip.warn("Update for an unknown subscription", {