paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

narrow_banner: Move empty narrow messages to handlebar templates.

Browse Source 
Removed existing empty narrow divs from app/home.html and created
a new javascript module to dynamically load empty narrow messages
using handlebar template.

Fixes #18797
This commit is contained in:
S-Abhishek
2021-09-01 21:53:28 +05:30
committed by Tim Abbott
parent 6381c2e535
commit 186d1a83e9
8 changed files with 543 additions and 275 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/tests/test_home.py
View File

@@ -219,7 +219,7 @@ class HomeTest(ZulipTestCase):
def test_home(self) -> None:
# Keep this list sorted!!!
html_bits = [
"start the conversation",
"empty_feed_notice_main",
"Loading...",
# Verify that the app styles get included
"app-stubentry.js",
@@ -446,7 +446,7 @@ class HomeTest(ZulipTestCase):
which still want the home page to load properly.
"""
html = result.content.decode()
if "start a conversation" not in html:
if "empty_feed_notice_main" not in html:
raise AssertionError("Home page probably did not load.")
def test_terms_of_service(self) -> None: