paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings_notifications: Rename variable to all_notification_settings.

Browse Source 
`all_notification_settings_labels` is misleading that this variable is a
list of notifications setting labels so changed it to
`all_notification_settings`.
This commit is contained in:
Pragati Agrawal
2020-03-22 19:54:27 +05:30
committed by Tim Abbott
parent b8945bafb4
commit 1871443d10
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/notifications.js
View File

@@ -749,7 +749,7 @@ exports.handle_global_notification_updates = function (notification_name, settin
// Update the global settings checked when determining if we should notify // Update the global settings checked when determining if we should notify
// for a given message. These settings do not affect whether or not a // for a given message. These settings do not affect whether or not a
// particular stream should receive notifications. // particular stream should receive notifications.
if (settings_notifications.all_notification_settings_labels.includes(notification_name)) { if (settings_notifications.all_notification_settings.includes(notification_name)) {
page_params[notification_name] = setting; page_params[notification_name] = setting;
} }

4
static/js/settings_notifications.js
View File

@@ -41,7 +41,7 @@ const notification_settings_status = [
{status_label: "stream-notify-settings-status", settings: stream_notification_settings}, {status_label: "stream-notify-settings-status", settings: stream_notification_settings},
]; ];
exports.all_notification_settings_labels = other_notification_settings.concat( exports.all_notification_settings = other_notification_settings.concat(
pm_mention_notification_settings, pm_mention_notification_settings,
stream_notification_settings stream_notification_settings
); );
@@ -138,7 +138,7 @@ exports.set_up = function () {
}; };
exports.update_page = function () { exports.update_page = function () {
for (const setting of exports.all_notification_settings_labels) { for (const setting of exports.all_notification_settings) {
if (setting === 'enable_offline_push_notifications' if (setting === 'enable_offline_push_notifications'
&& !page_params.realm_push_notifications_enabled) { && !page_params.realm_push_notifications_enabled) {
// If push notifications are disabled at the realm level, // If push notifications are disabled at the realm level,