paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

left sidebar: Change Home to All messages.

Browse Source 
We made this change because users often unnecessarily click "Home"
first in their use of Zulip, because it seems appealing.  While "All
messages" isn't quite precise (it doesn't include muted streams), it
does describe relatively simply the interleaved view that this
represents.

This commit leaves everything as "home" in the code, and only changes
user-visible strings and docs. Changing the code will be a big project;
there are hundreds of relevant occurrences in variable names, etc.

Further, we'll probably want to convert those various variable names
in different ways.

Tweaked by tabbott to extend the commit message and update a few comments.
This commit is contained in:
Rishi Gupta
2017-08-07 22:37:39 -07:00
committed by Tim Abbott
parent 1acdfef13c
commit 191f8f1b39
20 changed files with 55 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
docs/subsystems/pointer.md
View File

@@ -51,22 +51,22 @@ or in muted topics within non-muted streams.)
### Unnarrow: previous sequence
When you unnarrow using e.g. the escape key, you will automatically be
taken to the same message that was selected in the home view before
taken to the same message that was selected in the All messages view before
you narrowed, unless in the narrow you read new messages, in which
case you will be jumped forward to the first unread and non-muted
message in the home view (or the bottom of the feed if there is
none). This makes for a nice experience reading threads via the home
message in the All messages view (or the bottom of the feed if there is
none). This makes for a nice experience reading threads via the All messages
view in sequence.
### New home view: "high watermark"
### New All messages view: "high watermark"
When you open a new browser window or tab to the home view (a.k.a. the
When you open a new browser window or tab to the All messages view (a.k.a. the
interleaved view you get if you visit `/`), Zulip will select the
furthest down that your cursor has ever reached in the home
furthest down that your cursor has ever reached in the All messages
view. Because of the logic around unnarrowing in the last bullet, this
is usually just before the first unread message in the home view, but
if you never go to the home view, or you leave messages unread on some
streams in your home view, this can lag.
is usually just before the first unread message in the All messages view, but
if you never go to the All messages view, or you leave messages unread on some
streams in your All messages view, this can lag.
We plan to change this to automatically advance the pointer in a way
similar to the unnarrow logic.
@@ -75,7 +75,7 @@ similar to the unnarrow logic.
When you load a new browser tab or window to a narrowed view, Zulip
will select the message closest to your pointer, which is what you
would have got had you loaded the browser window to your home view and
would have got had you loaded the browser window to your All messages view and
then clicked on the nearest message matching your narrow (which might
have been offscreen).