paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

edit_fields_modal: Rename modal_body_html and modal_label.

Browse Source 
This commit renames modal_body_html and modal_label to
html_body and html_heading respectively. This change
will help us easily deduplicating the confirm_dialog
and edit_fields_modal code.
This commit is contained in:
sahil839
2021-07-05 15:05:18 +05:30
committed by Tim Abbott
parent 0edb413121
commit 19362f393e
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/edit_fields_modal.js
View File

@@ -27,7 +27,7 @@ import * as overlays from "./overlays";
*/
export function launch(modal_fields) {
const required_modal_fields = ["modal_label", "parent", "modal_body_html", "on_click"];
const required_modal_fields = ["html_heading", "parent", "html_body", "on_click"];
for (const field of required_modal_fields) {
if (!modal_fields[field]) {
@@ -36,7 +36,7 @@ export function launch(modal_fields) {
}
const html = render_edit_fields_modal({
modal_label: modal_fields.modal_label,
html_heading: modal_fields.html_heading,
});
const edit_fields_modal = $(html);
modal_fields.parent.append(edit_fields_modal);
@@ -45,7 +45,7 @@ export function launch(modal_fields) {
overlays.close_modal("#edit-fields-modal");
}
edit_fields_modal.find(".edit-fields-modal-body").html(modal_fields.modal_body_html);
edit_fields_modal.find(".edit-fields-modal-body").html(modal_fields.html_body);
if (modal_fields.post_render !== undefined) {
modal_fields.post_render();