paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Swap conditions for pre-filling narrows.

Browse Source 
This mostly sets up the next commit.  The two conditions here
are both inexpensive to check, but we want to bypass an upcoming
expensive operation if can_apply_locally() returns false.
This commit is contained in:
Steve Howell
2018-05-02 19:31:01 +00:00
committed by Tim Abbott
parent 66cd2edee4
commit 1941a0eb51
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/narrow.js
View File

@@ -184,11 +184,10 @@ exports.activate = function (raw_operators, opts) {
}
}
// Don't bother populating a message list when it won't contain
// the message we want anyway or if the filter can't be applied
// locally.
if (message_list.all.get(then_select_id) !== undefined) {
if (narrow_state.get_current_filter().can_apply_locally()) {
// Populate the message list if we can apply our filter locally (i.e.
// with no backend help) and we have the message we want to select.
if (narrow_state.get_current_filter().can_apply_locally()) {
if (message_list.all.get(then_select_id) !== undefined) {
message_util.add_messages(message_list.all.all_messages(), message_list.narrowed,
{delay_render: true});
}