From 196cf4367b72bccc441c52e26e64b44b12f237c1 Mon Sep 17 00:00:00 2001 From: Sampriti Panda Date: Fri, 13 Jan 2017 05:40:19 +0530 Subject: [PATCH] urls: Move /messages/render to POST endpoint --- api/zulip/__init__.py | 2 +- static/js/compose.js | 2 +- zerver/tests/test_bugdown.py | 4 ++-- zproject/urls.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/api/zulip/__init__.py b/api/zulip/__init__.py index 78e0011cca..e34922423d 100644 --- a/api/zulip/__init__.py +++ b/api/zulip/__init__.py @@ -681,7 +681,7 @@ class Client(object): ''' return self.call_endpoint( url='messages/render', - method='GET', + method='POST', request=request, ) diff --git a/static/js/compose.js b/static/js/compose.js index f2b9bebfe2..b09c3ed8e0 100644 --- a/static/js/compose.js +++ b/static/js/compose.js @@ -1038,7 +1038,7 @@ $(function () { // incorrect wrong, users will see a brief flicker). $("#preview_content").html(echo.apply_markdown(message)); } - channel.get({ + channel.post({ url: '/json/messages/render', idempotent: true, data: {content: message}, diff --git a/zerver/tests/test_bugdown.py b/zerver/tests/test_bugdown.py index 992adc5271..139e88e118 100644 --- a/zerver/tests/test_bugdown.py +++ b/zerver/tests/test_bugdown.py @@ -839,7 +839,7 @@ class BugdownApiTests(ZulipTestCase): def test_render_message_api(self): # type: () -> None content = 'That is a **bold** statement' - result = self.client_get( + result = self.client_post( '/api/v1/messages/render', dict(content=content), **self.api_auth('othello@zulip.com') @@ -853,7 +853,7 @@ class BugdownApiTests(ZulipTestCase): # type: () -> None """Determines whether we're correctly passing the realm context""" content = 'This mentions #**Denmark** and @**King Hamlet**.' - result = self.client_get( + result = self.client_post( '/api/v1/messages/render', dict(content=content), **self.api_auth('othello@zulip.com') diff --git a/zproject/urls.py b/zproject/urls.py index e4978bbe44..af227804ba 100644 --- a/zproject/urls.py +++ b/zproject/urls.py @@ -213,7 +213,7 @@ v1_api_and_json_patterns = [ {'GET': 'zerver.views.messages.json_fetch_raw_message', 'PATCH': 'zerver.views.messages.json_update_message'}), url(r'^messages/render$', rest_dispatch, - {'GET': 'zerver.views.messages.render_message_backend'}), + {'POST': 'zerver.views.messages.render_message_backend'}), url(r'^messages/flags$', rest_dispatch, {'POST': 'zerver.views.messages.update_message_flags'}),