From 19a434a289ee5508518564945b59b7f65aefe857 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Thu, 14 Feb 2019 15:54:39 +0000 Subject: [PATCH] user popover: Fix cropping/positioning. We use the `fix_positions` options every time we launch a user popover, whether it is from the message pane avatar or the buddy list chevron. For the message pane case, we can eliminate some complexity related to trying to put the menu above or below the avatar. We now always suggest "right", and if there are constraints due to being close to the edge of the screen, the fix_positions code will take care of it. --- static/js/popovers.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/static/js/popovers.js b/static/js/popovers.js index 84497b9864..6958cccef2 100644 --- a/static/js/popovers.js +++ b/static/js/popovers.js @@ -163,6 +163,7 @@ function render_user_info_popover(user, popover_element, is_sender_popover, priv user_is_guest: user.is_guest}), trigger: "manual", top_offset: 100, + fix_positions: true, }); popover_element.popover("show"); @@ -178,7 +179,6 @@ exports._test_calculate_info_popover_placement = calculate_info_popover_placemen // message is the message containing it, which should be selected function show_user_info_popover(element, user, message) { var last_popover_elem = current_message_info_popover_elem; - var popover_size = 428; // hardcoded pixel height of the popover popovers.hide_all(); if (last_popover_elem !== undefined && last_popover_elem.get()[0] === element) { @@ -198,7 +198,7 @@ function show_user_info_popover(element, user, message) { var is_sender_popover = message.sender_id === user.user_id; render_user_info_popover(user, elt, is_sender_popover, "respond_personal_button", - "message-info-popover", calculate_info_popover_placement(popover_size, elt)); + "message-info-popover", "right"); current_message_info_popover_elem = elt; }