From 19ae2f9180a87023895fcdc78c390516d8b781fd Mon Sep 17 00:00:00 2001 From: Sahil Singh Date: Sat, 4 Mar 2023 17:20:45 +0530 Subject: [PATCH] i18n: Add translation tags to loading message. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, no translation tag was present for 'Loading…' message. Fix this and also switch to using the … character instead of 3 . characters. --- web/src/attachments_ui.js | 6 ++++-- web/src/settings_users.js | 10 +++++++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/web/src/attachments_ui.js b/web/src/attachments_ui.js index 2fe92eab29..0c751fef6a 100644 --- a/web/src/attachments_ui.js +++ b/web/src/attachments_ui.js @@ -6,7 +6,7 @@ import render_uploaded_files_list from "../templates/settings/uploaded_files_lis import * as channel from "./channel"; import * as dialog_widget from "./dialog_widget"; -import {$t_html} from "./i18n"; +import {$t, $t_html} from "./i18n"; import * as ListWidget from "./list_widget"; import * as loading from "./loading"; import {page_params} from "./page_params"; @@ -148,7 +148,9 @@ export function set_up_attachments() { // The settings page must be rendered before this function gets called. const $status = $("#delete-upload-status"); - loading.make_indicator($("#attachments_loading_indicator"), {text: "Loading..."}); + loading.make_indicator($("#attachments_loading_indicator"), { + text: $t({defaultMessage: "Loading…"}), + }); $("#uploaded_files_table").on("click", ".remove-attachment", (e) => { const file_name = $(e.target).closest(".uploaded_file_row").attr("id"); diff --git a/web/src/settings_users.js b/web/src/settings_users.js index 111d621ac8..7f3d555ff9 100644 --- a/web/src/settings_users.js +++ b/web/src/settings_users.js @@ -274,7 +274,9 @@ function human_info(person) { let bot_list_widget; section.bots.create_table = () => { - loading.make_indicator($("#admin_page_bots_loading_indicator"), {text: "Loading..."}); + loading.make_indicator($("#admin_page_bots_loading_indicator"), { + text: $t({defaultMessage: "Loading…"}), + }); const $bots_table = $("#admin_bots_table"); $bots_table.hide(); const bot_user_ids = people.get_bot_ids(); @@ -407,9 +409,11 @@ export function redraw_bots_list() { } function start_data_load() { - loading.make_indicator($("#admin_page_users_loading_indicator"), {text: "Loading..."}); + loading.make_indicator($("#admin_page_users_loading_indicator"), { + text: $t({defaultMessage: "Loading…"}), + }); loading.make_indicator($("#admin_page_deactivated_users_loading_indicator"), { - text: "Loading...", + text: $t({defaultMessage: "Loading…"}), }); $("#admin_deactivated_users_table").hide(); $("#admin_users_table").hide();