paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 12:54:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

trello: Ignore dueComplete field.

Browse Source 
It's possible that this is a new name for the "due"
field, but it's not totally clear.

In the exception we saw in the field:

    payload['action']['data']['old']['dueComplete'] = False
    payload['action']['data']['card']['dueComplete'] = True
This commit is contained in:
Steve Howell
2020-08-22 12:33:01 +00:00
committed by Tim Abbott
parent 1bbf5491a7
commit 1a011b2adb
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
zerver/webhooks/trello/tests.py
View File

@@ -137,6 +137,7 @@ class TrelloHookTests(WebhookTestCase):
def test_ignoring_card_updates(self) -> None: def test_ignoring_card_updates(self) -> None:
fields = [ fields = [
"cover", "cover",
"dueComplete",
"idAttachmentCover", "idAttachmentCover",
"pos", "pos",
] ]

6
zerver/webhooks/trello/view/card_actions.py
View File

@@ -102,10 +102,12 @@ def get_proper_action(payload: Mapping[str, Any], action_type: str) -> Optional[
return ARCHIVE return ARCHIVE
if old_data.get('closed') and card_data.get('closed') is False: if old_data.get('closed') and card_data.get('closed') is False:
return REOPEN return REOPEN
# we don't support events for when a card is moved up or down # We don't support events for when a card is moved up or down
# within a single list (pos), or when the cover changes (cover) # within a single list (pos), or when the cover changes (cover).
# We also don't know if "dueComplete" is just a new name for "due".
ignored_fields = [ ignored_fields = [
"cover", "cover",
"dueComplete",
"idAttachmentCover", "idAttachmentCover",
"pos", "pos",
] ]