paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

require_server_admin: Cut a redundant bit of request-mutation.

Browse Source 
The only place this attribute is used is in `update_user_activity`,
called only in `process_client`, which won't happen if we end up
returning a redirect just below.  If we don't, we go and call
`add_logging_data` just after, which takes care of this already.
This commit is contained in:
Greg Price
2017-11-03 14:48:42 -07:00
committed by Tim Abbott
parent b871aa9622
commit 1a540241a9
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
zerver/decorator.py
View File

@@ -417,7 +417,6 @@ def require_server_admin(view_func):
@wraps(view_func) @wraps(view_func)
def _wrapped_view_func(request, *args, **kwargs): def _wrapped_view_func(request, *args, **kwargs):
# type: (HttpRequest, *Any, **Any) -> HttpResponse # type: (HttpRequest, *Any, **Any) -> HttpResponse
request._query = view_func.__name__
if not request.user.is_staff: if not request.user.is_staff:
return HttpResponseRedirect(settings.HOME_NOT_LOGGED_IN) return HttpResponseRedirect(settings.HOME_NOT_LOGGED_IN)