From 1ac9573a67621808eb835824f8278db802eb62bb Mon Sep 17 00:00:00 2001 From: Hari Prashant Bhimaraju Date: Sat, 8 Oct 2022 22:50:18 +0530 Subject: [PATCH] jotform: Strengthen types using WildValue. --- zerver/webhooks/jotform/view.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/zerver/webhooks/jotform/view.py b/zerver/webhooks/jotform/view.py index 8a5efaebc3..8f070c1f24 100644 --- a/zerver/webhooks/jotform/view.py +++ b/zerver/webhooks/jotform/view.py @@ -1,11 +1,11 @@ # Webhooks for external integrations. -from typing import Any, Dict from django.http import HttpRequest, HttpResponse from zerver.decorator import webhook_view from zerver.lib.request import REQ, has_request_variables from zerver.lib.response import json_success +from zerver.lib.validator import WildValue, check_string, to_wild_value from zerver.lib.webhooks.common import check_send_webhook_message from zerver.models import UserProfile @@ -15,11 +15,11 @@ from zerver.models import UserProfile def api_jotform_webhook( request: HttpRequest, user_profile: UserProfile, - payload: Dict[str, Any] = REQ(argument_type="body"), + payload: WildValue = REQ(argument_type="body", converter=to_wild_value), ) -> HttpResponse: - topic = payload["formTitle"] - submission_id = payload["submissionID"] - fields_dict = list(payload["pretty"].split(", ")) + topic = payload["formTitle"].tame(check_string) + submission_id = payload["submissionID"].tame(check_string) + fields_dict = list(payload["pretty"].tame(check_string).split(", ")) form_response = f"A new submission (ID {submission_id}) was received:\n" for field in fields_dict: