paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

popover: Rename show_user_info_popover function.

Browse Source 
This commit renames the show_user_info_popover function to
show_user_info_popover_for_message, as it is used to open
the popover for users which are essentially related to a
particular message, like message sender and mentioned user.
This commit is contained in:
sahil839
2020-06-25 17:48:37 +05:30
committed by Tim Abbott
parent 572b3930e7
commit 1acfb4e942
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/popovers.js
View File

@@ -247,7 +247,7 @@ exports._test_calculate_info_popover_placement = calculate_info_popover_placemen
// element is the target element to pop off of // element is the target element to pop off of
// user is the user whose profile to show // user is the user whose profile to show
// message is the message containing it, which should be selected // message is the message containing it, which should be selected
function show_user_info_popover(element, user, message) { function show_user_info_popover_for_message(element, user, message) {
const last_popover_elem = current_message_info_popover_elem; const last_popover_elem = current_message_info_popover_elem;
exports.hide_all(); exports.hide_all();
if (last_popover_elem !== undefined && last_popover_elem.get()[0] === element) { if (last_popover_elem !== undefined && last_popover_elem.get()[0] === element) {
@@ -701,7 +701,7 @@ exports.show_sender_info = function () {
const message = current_msg_list.get(rows.id($message)); const message = current_msg_list.get(rows.id($message));
const user = people.get_by_user_id(message.sender_id); const user = people.get_by_user_id(message.sender_id);
show_user_info_popover($sender[0], user, message); show_user_info_popover_for_message($sender[0], user, message);
if (current_message_info_popover_elem) { if (current_message_info_popover_elem) {
focus_user_info_popover_item(); focus_user_info_popover_item();
} }
@@ -733,8 +733,7 @@ exports.register_click_handlers = function () {
e.stopPropagation(); e.stopPropagation();
const message = current_msg_list.get(rows.id(row)); const message = current_msg_list.get(rows.id(row));
const user = people.get_by_user_id(message.sender_id); const user = people.get_by_user_id(message.sender_id);
show_user_info_popover_for_message(this, user, message);
show_user_info_popover(this, user, message);
}, },
); );
@@ -756,7 +755,7 @@ exports.register_click_handlers = function () {
} else { } else {
user = people.get_by_email(email); user = people.get_by_email(email);
} }
show_user_info_popover(this, user, message); show_user_info_popover_for_message(this, user, message);
}); });
$("#main_div").on("click", ".user-group-mention", function (e) { $("#main_div").on("click", ".user-group-mention", function (e) {