From 1afc730da7ec6ff1b59a0f0e35989729ef154da3 Mon Sep 17 00:00:00 2001 From: Sahil Batra Date: Thu, 16 Feb 2023 15:27:08 +0530 Subject: [PATCH] settings: Add settings_select class to select elements. This commit adds settings_select class to select elements in user and organization settings, such that we can add CSS using this class and not using "select" as selector so that we can easily add a select element in future with different CSS if needed. --- static/styles/settings.css | 2 +- .../templates/settings/account_settings.hbs | 2 +- .../settings/custom_user_profile_field.hbs | 2 +- .../templates/settings/display_settings.hbs | 8 ++-- .../settings/notification_settings.hbs | 6 +-- .../organization_permissions_admin.hbs | 38 +++++++++---------- .../settings/organization_profile_admin.hbs | 2 +- .../settings/organization_settings_admin.hbs | 8 ++-- .../organization_user_settings_defaults.hbs | 2 +- .../templates/settings/profile_settings.hbs | 2 +- 10 files changed, 36 insertions(+), 36 deletions(-) diff --git a/static/styles/settings.css b/static/styles/settings.css index ae3032b8d9..391fe56323 100644 --- a/static/styles/settings.css +++ b/static/styles/settings.css @@ -355,7 +355,7 @@ td .button { color: hsl(0, 0%, 20%); } - select { + .settings_select { height: 30px; width: 220px; padding: 4px 6px; diff --git a/static/templates/settings/account_settings.hbs b/static/templates/settings/account_settings.hbs index b7d4b26e94..e10842bf2c 100644 --- a/static/templates/settings/account_settings.hbs +++ b/static/templates/settings/account_settings.hbs @@ -82,7 +82,7 @@ - diff --git a/static/templates/settings/custom_user_profile_field.hbs b/static/templates/settings/custom_user_profile_field.hbs index 2ecf33532b..9e27dfecff 100644 --- a/static/templates/settings/custom_user_profile_field.hbs +++ b/static/templates/settings/custom_user_profile_field.hbs @@ -6,7 +6,7 @@ {{#if is_long_text_field}} {{else if is_select_field}} - {{#each field_choices}} diff --git a/static/templates/settings/display_settings.hbs b/static/templates/settings/display_settings.hbs index 7f8b234eca..3bfd67aa63 100644 --- a/static/templates/settings/display_settings.hbs +++ b/static/templates/settings/display_settings.hbs @@ -19,7 +19,7 @@
- {{#each twenty_four_hour_time_values}} {{/each}} @@ -37,7 +37,7 @@
- {{> dropdown_options_widget option_values=color_scheme_values}}
@@ -118,7 +118,7 @@ - {{> dropdown_options_widget option_values=default_view_values}}
@@ -133,7 +133,7 @@ - {{> dropdown_options_widget option_values=demote_inactive_streams_values}} diff --git a/static/templates/settings/notification_settings.hbs b/static/templates/settings/notification_settings.hbs index 4d28a2a400..7d9902c1e9 100644 --- a/static/templates/settings/notification_settings.hbs +++ b/static/templates/settings/notification_settings.hbs @@ -74,7 +74,7 @@
- +
@@ -129,7 +129,7 @@ - {{#each email_notifications_batching_period_values}} {{/each}} diff --git a/static/templates/settings/organization_permissions_admin.hbs b/static/templates/settings/organization_permissions_admin.hbs index 9b0200bfa2..f3eeb6b501 100644 --- a/static/templates/settings/organization_permissions_admin.hbs +++ b/static/templates/settings/organization_permissions_admin.hbs @@ -18,14 +18,14 @@ label=admin_settings_label.realm_invite_required}} - {{> dropdown_options_widget option_values=invite_to_realm_policy_values}}
- @@ -42,7 +42,7 @@ {{t "Waiting period before new members turn into full members" }} {{> ../help_link_widget link="/help/restrict-permissions-of-new-members" }} - {{> dropdown_options_widget option_values=waiting_period_threshold_dropdown_values}} {{!-- This setting is hidden unless `custom_period` --}} @@ -91,7 +91,7 @@
- {{> dropdown_options_widget option_values=common_policy_values}}
@@ -105,19 +105,19 @@ help_link="/help/public-access-option"}}
- {{> dropdown_options_widget option_values=create_web_public_stream_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
@@ -125,7 +125,7 @@ - {{> dropdown_options_widget option_values=wildcard_mention_policy_values}}
@@ -154,7 +154,7 @@
- {{#each msg_edit_limit_dropdown_values}} {{/each}} @@ -183,14 +183,14 @@
- {{> dropdown_options_widget option_values=edit_topic_policy_values}}
- {{#each msg_move_limit_dropdown_values}} {{/each}} @@ -209,14 +209,14 @@
- {{> dropdown_options_widget option_values=move_messages_between_streams_policy_values}}
- {{#each msg_move_limit_dropdown_values}} {{/each}} @@ -248,7 +248,7 @@ - {{> dropdown_options_widget option_values=common_message_policy_values}}
@@ -257,7 +257,7 @@ - {{#each msg_delete_limit_dropdown_values}} {{/each}} @@ -284,21 +284,21 @@
- {{> dropdown_options_widget option_values=bot_creation_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
@@ -307,7 +307,7 @@ - {{> dropdown_options_widget option_values=private_message_policy_values}}
diff --git a/static/templates/settings/organization_profile_admin.hbs b/static/templates/settings/organization_profile_admin.hbs index 6ed2dbb265..c42c646380 100644 --- a/static/templates/settings/organization_profile_admin.hbs +++ b/static/templates/settings/organization_profile_admin.hbs @@ -21,7 +21,7 @@ - {{> dropdown_options_widget option_values=realm_org_type_values}}
diff --git a/static/templates/settings/organization_settings_admin.hbs b/static/templates/settings/organization_settings_admin.hbs index 3f4bd24dd7..0ea07e0dfe 100644 --- a/static/templates/settings/organization_settings_admin.hbs +++ b/static/templates/settings/organization_settings_admin.hbs @@ -23,7 +23,7 @@ @@ -105,7 +105,7 @@ - {{#each realm_available_video_chat_providers}} {{/each}} @@ -116,7 +116,7 @@ {{t 'GIPHY integration' }} {{> ../help_link_widget link=giphy_help_link }} - {{#each giphy_rating_options}} {{/each}} diff --git a/static/templates/settings/organization_user_settings_defaults.hbs b/static/templates/settings/organization_user_settings_defaults.hbs index db9e548c0c..aaf3888c4d 100644 --- a/static/templates/settings/organization_user_settings_defaults.hbs +++ b/static/templates/settings/organization_user_settings_defaults.hbs @@ -33,7 +33,7 @@ - diff --git a/static/templates/settings/profile_settings.hbs b/static/templates/settings/profile_settings.hbs index 003ecf4411..42e35a2613 100644 --- a/static/templates/settings/profile_settings.hbs +++ b/static/templates/settings/profile_settings.hbs @@ -20,7 +20,7 @@
- {{#unless settings_object.timezone}} {{/unless}}