paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

mark as read: Fix banner not closing when x is clicked.

Browse Source 
Previously, the X in the mark-as-read banner did nothing.
This commit is contained in:
evykassirer
2022-03-29 12:50:43 -07:00
committed by Tim Abbott
parent a434b0ef19
commit 1b24bfcc31
4 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
static/js/unread_ui.js
View File

@@ -14,9 +14,22 @@ import * as unread from "./unread";
import {notify_server_messages_read} from "./unread_ops";
let last_mention_count = 0;
let user_closed_mark_as_read_turned_off_banner = false;
export function hide_mark_as_read_turned_off_banner() {
$("#mark_as_read_turned_off_banner").hide();
// Use visibility instead of hide() to prevent messages on the screen from
// shifting vertically.
$("#mark_as_read_turned_off_banner").toggleClass("invisible", true);
}
export function reset_mark_as_read_turned_off_banner() {
hide_mark_as_read_turned_off_banner();
user_closed_mark_as_read_turned_off_banner = false;
}
export function notify_messages_remain_unread() {
if (!user_closed_mark_as_read_turned_off_banner) {
$("#mark_as_read_turned_off_banner").toggleClass("invisible", false);
}
}
function do_new_messages_animation($li) {
@@ -97,15 +110,11 @@ export function should_display_bankruptcy_banner() {
return false;
}
export function notify_messages_remain_unread() {
$("#mark_as_read_turned_off_banner").show();
}
export function initialize() {
update_unread_counts();
$("#mark_as_read_turned_off_banner").html(render_mark_as_read_turned_off_banner());
$("#mark_as_read_turned_off_banner").hide();
hide_mark_as_read_turned_off_banner();
$("#mark_view_read").on("click", () => {
// Mark all messages in the current view as read.
//
@@ -117,6 +126,10 @@ export function initialize() {
.filter((message) => unread.message_unread(message));
notify_server_messages_read(unread_messages);
$("#mark_as_read_turned_off_banner").hide();
hide_mark_as_read_turned_off_banner();
});
$("#mark_as_read_close").on("click", () => {
hide_mark_as_read_turned_off_banner();
user_closed_mark_as_read_turned_off_banner = true;
});
}