paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

timerender: Make moment() return static date.

Browse Source 
The previous iteration of the test was flaky when we could get
off by one errors between two moment() calls.
This commit is contained in:
Rohitt Vashishtha
2020-07-07 08:55:09 +05:30
committed by Steve Howell
parent 7079897119
commit 1d3234b6c6
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend_tests/node_tests/timerender.js
View File

@@ -135,10 +135,18 @@ run_test('get_timestamp_for_flatpickr', () => {
const unix_timestamp = 1495091573000; // 5/18/2017 7:12:53 AM (UTC+0)
const iso_timestamp = '2017-05-18T07:12:53Z'; // ISO 8601 date format
const func = timerender.get_timestamp_for_flatpickr;
// Freeze time for testing.
const date_now = Date.now;
Date.now = () => new Date('2020-07-07T10:00:00Z').getTime();
// Invalid timestamps should show current time.
assert.equal(func("random str").valueOf(), moment().valueOf());
// Valid ISO timestamps should return Date objects.
assert.equal(func(iso_timestamp).valueOf(), moment(unix_timestamp).valueOf());
// Restore the Date object.
Date.now = date_now;
});
run_test('absolute_time_12_hour', () => {