paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 16:43:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

unread_ui: Refactor method to update unread banner.

Browse Source 
This commit refactors the "update_unread_banner", so that
the "mark_read_on_scroll_state_banner" innerHtml is
set using a separate method by passing the necessary
template.

This is a preparatory commit.
This commit is contained in:
roanster007
2024-06-07 15:22:11 +05:30
committed by Tim Abbott
parent 8d29e1829f
commit 1d3da31b8b
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/unread_ui.ts
View File

@@ -23,6 +23,10 @@ export function register_update_unread_counts_hook(f: UpdateUnreadCountsHook): v
update_unread_counts_hooks.push(f); update_unread_counts_hooks.push(f);
} }
function set_mark_read_on_scroll_state_banner(template: string): void {
$("#mark_read_on_scroll_state_banner").html(template);
}
export function update_unread_banner(): void { export function update_unread_banner(): void {
if (message_lists.current === undefined) { if (message_lists.current === undefined) {
return; return;
@@ -34,17 +38,15 @@ export function update_unread_banner(): void {
user_settings.web_mark_read_on_scroll_policy === user_settings.web_mark_read_on_scroll_policy ===
web_mark_read_on_scroll_policy_values.never.code web_mark_read_on_scroll_policy_values.never.code
) { ) {
$("#mark_read_on_scroll_state_banner").html(render_mark_as_read_disabled_banner()); set_mark_read_on_scroll_state_banner(render_mark_as_read_disabled_banner());
} else if ( } else if (
user_settings.web_mark_read_on_scroll_policy === user_settings.web_mark_read_on_scroll_policy ===
web_mark_read_on_scroll_policy_values.conversation_only.code && web_mark_read_on_scroll_policy_values.conversation_only.code &&
!is_conversation_view !is_conversation_view
) { ) {
$("#mark_read_on_scroll_state_banner").html( set_mark_read_on_scroll_state_banner(render_mark_as_read_only_in_conversation_view());
render_mark_as_read_only_in_conversation_view(),
);
} else { } else {
$("#mark_read_on_scroll_state_banner").html(render_mark_as_read_turned_off_banner()); set_mark_read_on_scroll_state_banner(render_mark_as_read_turned_off_banner());
if (message_lists.current.can_mark_messages_read_without_setting()) { if (message_lists.current.can_mark_messages_read_without_setting()) {
hide_unread_banner(); hide_unread_banner();
} }