paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-19 14:08:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

reactions: Use parameter destructuring in insert_new_reaction.

Browse Source 
This is a pure code refactor for readability.
This commit is contained in:
YashRE42
2021-12-17 16:44:52 +05:30
committed by Tim Abbott
parent 0438ed5777
commit 1dffad98fa
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/reactions.js
View File

@@ -303,31 +303,29 @@ view.update_existing_reaction = function ({
} }
}; };
view.insert_new_reaction = function (opts) { view.insert_new_reaction = function ({message_id, user_id, emoji_name, emoji_code, reaction_type}) {
// Our caller ensures we are the first user to react to this // Our caller ensures we are the first user to react to this
// message with this emoji, and it populates user_list for // message with this emoji, and it populates user_list for
// us. We then render the emoji/title/count and insert it // us. We then render the emoji/title/count and insert it
// before the add button. // before the add button.
const message_id = opts.message_id;
const user_id = opts.user_id;
const user_list = [user_id]; const user_list = [user_id];
const context = { const context = {
message_id, message_id,
...emoji.get_emoji_details_for_rendering(opts), ...emoji.get_emoji_details_for_rendering({emoji_name, emoji_code, reaction_type}),
}; };
const new_label = generate_title(opts.emoji_name, user_list); const new_label = generate_title(emoji_name, user_list);
context.count = 1; context.count = 1;
context.label = new_label; context.label = new_label;
context.local_id = get_local_reaction_id(opts); context.local_id = get_local_reaction_id({reaction_type, emoji_code});
context.emoji_alt_code = user_settings.emojiset === "text"; context.emoji_alt_code = user_settings.emojiset === "text";
context.is_realm_emoji = context.is_realm_emoji =
context.reaction_type === "realm_emoji" || context.reaction_type === "zulip_extra_emoji"; context.reaction_type === "realm_emoji" || context.reaction_type === "zulip_extra_emoji";
if (opts.user_id === page_params.user_id) { if (user_id === page_params.user_id) {
context.class = "message_reaction reacted"; context.class = "message_reaction reacted";
} else { } else {
context.class = "message_reaction"; context.class = "message_reaction";