paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_list: Use more direct code in build_stream_list.

Browse Source 
We eliminate `.get(0)` calls in buld_stream_list.

The easy case is that we stop building jQuery objects
for the splitters only to pull out the DOM immediately.

The more subtle case is that we also don't do `.get(0)` calls
to get DOM out of our individual list items.  By passing
in full jQuery objects to `append()`, we should prevent ourself
from orphaning the old objects, which may in the future have
things like tooltip logic attached to them.
This commit is contained in:
Steve Howell
2017-07-18 07:30:14 -04:00
committed by Tim Abbott
parent 2317819e47
commit 1ed35be88c
2 changed files with 19 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
frontend_tests/node_tests/stream_list.js
View File

@@ -86,16 +86,9 @@ set_global('topic_list', {});
assert.equal(social_value.text(), '42');
}());
function set_getter(elem, stub_value) {
elem.get = function (idx) {
assert.equal(idx, 0);
return stub_value;
};
}
set_getter($('<hr class="stream-split">'), 'split');
set_getter($('<devel sidebar row>'), 'devel-sidebar');
set_getter($('<social sidebar row>'), 'social-sidebar');
var split = '<hr class="stream-split">';
var devel_sidebar = $('<devel sidebar row>');
var social_sidebar = $('<social sidebar row>');
var appended_elems;
$('#stream_filters').append = function (elems) {
@@ -105,9 +98,9 @@ set_global('topic_list', {});
stream_list.build_stream_list();
var expected_elems = [
'split',
'devel-sidebar',
'social-sidebar',
split,
devel_sidebar,
social_sidebar,
];
assert.deepEqual(appended_elems, expected_elems);
@@ -333,16 +326,18 @@ function initialize_stream_data() {
stream_list.build_stream_list();
var split = '<hr class="stream-split">';
var expected_elems = [
'<devel sidebar row html>',
'<Rome sidebar row html>',
'<test sidebar row html>',
'split',
'<announce sidebar row html>',
'<Denmark sidebar row html>',
'split',
'<cars sidebar row html>',
$('<devel sidebar row html>'),
$('<Rome sidebar row html>'),
$('<test sidebar row html>'),
split,
$('<announce sidebar row html>'),
$('<Denmark sidebar row html>'),
split,
$('<cars sidebar row html>'),
];
assert.deepEqual(appended_elems, expected_elems);
var streams = global.stream_sort.get_streams();