paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

page_params: Make seperate page_params for billing module.

Browse Source 
This commit introduces a seperate `page_params` file for billing module
since we only use certain page_params in billing module only that it does
not make sense to include them in the main `page_params.ts`.

Also introduced `zpage_billing_params` for proper testing new `page_params`
in billing module.
This commit is contained in:
Lalit
2023-03-18 23:31:20 +05:30
committed by Tim Abbott
parent e360a896f6
commit 1f4dd0705d
9 changed files with 40 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/tests/billing_helpers.test.js
View File

@@ -10,7 +10,7 @@ const {mock_esm, set_global, zrequire} = require("./lib/namespace");
const jQueryFactory = require("./lib/real_jquery");
const {run_test} = require("./lib/test");
const $ = require("./lib/zjquery");
const {page_params} = require("./lib/zpage_params");
const {page_params} = require("./lib/zpage_billing_params");
const template = fs.readFileSync(
path.resolve(__dirname, "../../templates/corporate/upgrade.html"),

4
web/tests/lib/index.js
View File

@@ -15,6 +15,7 @@ const namespace = require("./namespace");
const test = require("./test");
const blueslip = require("./zblueslip");
const zjquery = require("./zjquery");
const zpage_billing_params = require("./zpage_billing_params");
const zpage_params = require("./zpage_params");
process.env.NODE_ENV = "test";
@@ -110,12 +111,15 @@ test.set_verbose(files.length === 1);
ls_container.clear();
_.throttle = immediate;
_.debounce = immediate;
zpage_billing_params.reset();
zpage_params.reset();
namespace.mock_esm("../../src/blueslip", blueslip);
require("../../src/blueslip");
namespace.mock_esm("../../src/i18n", stub_i18n);
require("../../src/i18n");
namespace.mock_esm("../../src/billing/page_params", zpage_billing_params);
require("../../src/billing/page_params");
namespace.mock_esm("../../src/page_params", zpage_params);
require("../../src/page_params");
namespace.mock_esm("../../src/user_settings", zpage_params);

2
web/tests/lib/test.js
View File

@@ -3,6 +3,7 @@
const namespace = require("./namespace");
const zblueslip = require("./zblueslip");
const $ = require("./zjquery");
const zpage_billing_params = require("./zpage_billing_params");
const zpage_params = require("./zpage_params");
let current_file_name;
@@ -29,6 +30,7 @@ async function execute_test(label, f, opts) {
if (!sloppy_$ && $.clear_all_elements) {
$.clear_all_elements();
}
zpage_billing_params.reset();
zpage_params.reset();
try {

11
web/tests/lib/zpage_billing_params.js Normal file
View File

@@ -0,0 +1,11 @@
"use strict";
exports.page_params = {};
exports.reset = () => {
for (const field in exports.page_params) {
if (Object.hasOwn(exports.page_params, field)) {
delete exports.page_params[field];
}
}
};

2
web/tests/upgrade.test.js
View File

@@ -9,7 +9,7 @@ const {JSDOM} = require("jsdom");
const {set_global, zrequire} = require("./lib/namespace");
const {run_test} = require("./lib/test");
const $ = require("./lib/zjquery");
const {page_params} = require("./lib/zpage_params");
const {page_params} = require("./lib/zpage_billing_params");
const noop = () => {};
const template = fs.readFileSync(