paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream settings: Add name attr to settings elements.

Browse Source 
Add `name` attribute to stream settings `input` elements
and change `id` attribute corresponding to name.
`name` attribute stores value of settings name which is
stored in frontend data sets.
This commit is contained in:
Yashashvi Dave
2019-06-14 13:57:48 +05:30
committed by Tim Abbott
parent de1f4066ba
commit 1f5720d1b8
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/stream_events.js
View File

@@ -124,7 +124,7 @@ run_test('update_property', () => {
with_overrides(function (override) {
override('stream_list.refresh_pinned_or_unpinned_stream', noop);
stream_events.update_property(1, 'pin_to_top', true);
checkbox = $('#pinstream-1');
checkbox = $(".subscription_settings[data-stream-id='1'] #sub_pin_to_top_setting .sub_setting_control");
assert.equal(checkbox.prop('checked'), true);
});