paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

navigate: Use msg_list.prev/next for up/down methods.

Browse Source 
We've had rare and hard-to-track-down glitches with our
old implementation for going up and down in the message
list, which was using jQuery selectors.

We now just use MessageListData under the hood to find
our next id.
This commit is contained in:
Steve Howell
2018-05-26 10:36:24 +00:00
committed by Tim Abbott
parent a074056127
commit 1f72647a5a
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/navigate.js
View File

@@ -3,27 +3,30 @@ var navigate = (function () {
var exports = {};
function go_to_row(row) {
current_msg_list.select_id(rows.id(row),
function go_to_row(msg_id) {
current_msg_list.select_id(msg_id,
{then_scroll: true,
from_scroll: true});
}
exports.up = function () {
message_viewport.last_movement_direction = -1;
var next_row = rows.prev_visible(current_msg_list.selected_row());
if (next_row.length !== 0) {
go_to_row(next_row);
var msg_id = current_msg_list.prev();
if (msg_id === undefined) {
return;
}
go_to_row(msg_id);
};
exports.down = function (with_centering) {
message_viewport.last_movement_direction = 1;
var next_row = rows.next_visible(current_msg_list.selected_row());
if (next_row.length !== 0) {
go_to_row(next_row);
var msg_id = current_msg_list.next();
if (msg_id === undefined) {
return;
}
if (with_centering && (next_row.length === 0)) {
go_to_row(msg_id);
if (with_centering) {
// At the last message, scroll to the bottom so we have
// lots of nice whitespace for new messages coming in.
//