paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

css: Use em instead of base font size css variable for small buttons.

Browse Source 
Clearing the pending TODO to use em instead of calc and the
`--base-font-size-px` variable.
This commit is contained in:
Shubham Padia
2025-01-06 07:22:49 +00:00
committed by Tim Abbott
parent 01793b0de3
commit 213c9e6a7a
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
web/styles/app_components.css
View File

@@ -154,18 +154,8 @@ input::placeholder {
} }
&.small { &.small {
/* This value was 0.8rem in the past. When using rem, /* 16 / 14 * 0.8 = 0.9143, from original 0.8rem */
the root font size was 16px when the base font-size was font-size: 0.9143em;
14px. Now, we have two modes, one with 14px base
font-size and one with 16px base font-size. We multiply
by (16 / 14 * 0.8 = 0.9143) so rem equivalent value
will remain the same in the legacy 14px mode, while
scaling the size up for 16px mode. The font-size will
resolve in pixels.
TODO: Refactor this part to either use `em` or `rem`
and not this temporary hack of using calc() and
variables. */
font-size: calc(0.9143 * var(--base-font-size-px));
min-width: inherit; min-width: inherit;
padding: 6px 10px; padding: 6px 10px;
} }