paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

urls: Delete the json/tutorial_send_message endpoint.

Browse Source 
This endpoint is part of the old tutorial, which we've removed, and
has some security downsides as well.

This includes a minor refactoring of the tests.
This commit is contained in:
Alena Volkova
2017-10-04 15:37:37 -04:00
committed by Tim Abbott
parent 5a80c029a2
commit 21bc0e845c
3 changed files with 4 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
zerver/views/tutorial.py
View File

@@ -1,33 +1,11 @@
from django.utils.translation import ugettext as _
from django.http import HttpRequest, HttpResponse
from zerver.decorator import authenticated_json_post_view, has_request_variables, REQ
from zerver.lib.actions import internal_send_message
from zerver.lib.response import json_error, json_success
from zerver.lib.response import json_success
from zerver.lib.validator import check_string
from zerver.models import UserProfile
@authenticated_json_post_view
@has_request_variables
def json_tutorial_send_message(request, user_profile, type=REQ(validator=check_string),
recipient=REQ(validator=check_string), topic=REQ(validator=check_string),
content=REQ(validator=check_string)):
# type: (HttpRequest, UserProfile, str, str, str, str) -> HttpResponse
"""
This function, used by the onboarding tutorial, causes the Tutorial Bot to
send you the message you pass in here. (That way, the Tutorial Bot's
messages to you get rendered by the server and therefore look like any other
message.)
"""
sender_name = "welcome-bot@zulip.com"
if type == 'stream':
internal_send_message(user_profile.realm, sender_name,
"stream", recipient, topic, content)
return json_success()
# For now, there are no PM cases.
return json_error(_('Bad data passed in to tutorial_send_message'))
@authenticated_json_post_view
@has_request_variables
def json_tutorial_status(request, user_profile,