paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Avoid triggers in stream_edit.

Browse Source 
We extract stream_edit.rerender to make
the live-update code easier to follow.

The function should eventually be inlined,
but I want to clean up some other stuff first.
This commit is contained in:
Steve Howell
2020-06-12 17:47:13 +00:00
committed by Tim Abbott
parent 186973cde2
commit 22bf4696f5
3 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/server_events_dispatch.js
View File

@@ -334,7 +334,7 @@ exports.dispatch_normal_event = function dispatch_normal_event(event) {
return;
}
$(document).trigger('peer_subscribe.zulip', {stream_name: stream_name});
stream_edit.rerender(stream_name);
}
for (const stream_name of event.subscriptions) {
add_peer(stream_name, event.user_id);
@@ -346,7 +346,7 @@ exports.dispatch_normal_event = function dispatch_normal_event(event) {
blueslip.warn('Cannot process peer_remove event.');
return;
}
$(document).trigger('peer_unsubscribe.zulip', {stream_name: stream_name});
stream_edit.rerender(stream_name);
}
for (const stream_name of event.subscriptions) {
remove_peer(stream_name, event.user_id);