paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Fix inappropriate assertEqual.

Browse Source 
We do not give a second argument to `self.assertEqual` here. We only need
to invoke the function.
This commit is contained in:
PIG208
2021-07-27 02:08:06 +08:00
committed by Tim Abbott
parent 91de2cbe03
commit 22c84e69ac
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/tests/test_decorators.py
View File

@@ -762,11 +762,11 @@ class ValidatorTestCase(ZulipTestCase):
def test_to_non_negative_int(self) -> None: def test_to_non_negative_int(self) -> None:
self.assertEqual(to_non_negative_int("5"), 5) self.assertEqual(to_non_negative_int("5"), 5)
with self.assertRaisesRegex(ValueError, "argument is negative"): with self.assertRaisesRegex(ValueError, "argument is negative"):
self.assertEqual(to_non_negative_int("-1")) to_non_negative_int("-1")
with self.assertRaisesRegex(ValueError, re.escape("5 is too large (max 4)")): with self.assertRaisesRegex(ValueError, re.escape("5 is too large (max 4)")):
self.assertEqual(to_non_negative_int("5", max_int_size=4)) to_non_negative_int("5", max_int_size=4)
with self.assertRaisesRegex(ValueError, re.escape(f"{2**32} is too large (max {2**32-1})")): with self.assertRaisesRegex(ValueError, re.escape(f"{2**32} is too large (max {2**32-1})")):
self.assertEqual(to_non_negative_int(str(2 ** 32))) to_non_negative_int(str(2 ** 32))
def test_to_positive_or_allowed_int(self) -> None: def test_to_positive_or_allowed_int(self) -> None:
self.assertEqual(to_positive_or_allowed_int()("5"), 5) self.assertEqual(to_positive_or_allowed_int()("5"), 5)