paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_data: Delete partial_subscribers off of sub creation attrs.

Browse Source 
Followup to https://github.com/zulip/zulip/pull/34960#discussion_r2176959839
This commit is contained in:
Evy Kassirer
2025-08-20 20:49:20 -07:00
committed by Tim Abbott
parent 92fbe47a3b
commit 22ca76ba2b
2 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/stream_data.ts
View File

@@ -1075,9 +1075,11 @@ export function create_sub_from_server_data(
// a copy of the object with `_.omit(attrs, 'subscribers')`, but `_.omit` is
// slow enough to show up in timings when you have 1000s of streams.
const subscriber_user_ids = attrs.subscribers;
const full_data = attrs.partial_subscribers === undefined;
const subscriber_user_ids = full_data ? attrs.subscribers : attrs.partial_subscribers;
delete attrs.subscribers;
delete attrs.partial_subscribers;
sub = {
render_subscribers: !realm.realm_is_zephyr_mirror_realm || attrs.invite_only,
@@ -1104,11 +1106,7 @@ export function create_sub_from_server_data(
stream_ids_by_name.set(sub.name, sub.stream_id);
sub_store.add_hydrated_sub(sub.stream_id, sub);
if (attrs.partial_subscribers !== undefined) {
peer_data.set_subscribers(sub.stream_id, attrs.partial_subscribers, false);
} else {
peer_data.set_subscribers(sub.stream_id, subscriber_user_ids ?? []);
}
peer_data.set_subscribers(sub.stream_id, subscriber_user_ids ?? [], full_data);
return sub;
}

1
web/tests/stream_data.test.cjs
View File

@@ -1271,7 +1271,6 @@ test("create_sub", () => {
const antarctica_sub = stream_data.create_sub_from_server_data(antarctica);
assert.ok(antarctica_sub);
assert.equal(antarctica_sub.color, "#76ce90");
assert.deepEqual(antarctica_sub.partial_subscribers, [1, 2, 3]);
});
test("creator_id", ({override}) => {