paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-21 15:09:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

notifications: Extract should_send_*_notification for testing.

Browse Source
This commit is contained in:
Tim Abbott
2019-12-10 12:54:08 -08:00
parent 016487163f
commit 22cefeede8
2 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/notifications.js
View File

@@ -490,7 +490,7 @@ exports.message_is_notifiable = function (message) {
return true;
};
function should_send_desktop_notification(message) {
exports.should_send_desktop_notification = function (message) {
// For streams, send if desktop notifications are enabled for this
// stream.
if (message.type === "stream" &&
@@ -518,9 +518,9 @@ function should_send_desktop_notification(message) {
}
return false;
}
};
function should_send_audible_notification(message) {
exports.should_send_audible_notification = function (message) {
// For streams, ding if sounds are enabled for this stream.
if (message.type === "stream" &&
stream_data.receives_notifications(message.stream, "audible_notifications")) {
@@ -542,7 +542,7 @@ function should_send_audible_notification(message) {
}
return false;
}
};
exports.granted_desktop_notifications_permission = function () {
return notifications_api &&
@@ -569,13 +569,13 @@ exports.received_messages = function (messages) {
message.notification_sent = true;
if (should_send_desktop_notification(message)) {
if (exports.should_send_desktop_notification(message)) {
process_notification({
message: message,
desktop_notify: exports.granted_desktop_notifications_permission(),
});
}
if (should_send_audible_notification(message) && supports_sound) {
if (exports.should_send_audible_notification(message) && supports_sound) {
$("#notifications-area").find("audio")[0].play();
}
});