paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 00:46:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

event_queue: Reorder maybe_enqueue_for_update parameters.

Browse Source 
This will make `maybe_enqueue_notifications_for_message_update`'s
arguments more consistent with `maybe_enqueue_notifications`.
This commit is contained in:
Abhijeet Prasad Bodas
2021-06-07 16:13:39 +05:30
parent 99b181629d
commit 22d19375f2
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
zerver/tornado/event_queue.py
View File

@@ -1139,14 +1139,15 @@ def process_message_update_event(
maybe_enqueue_notifications_for_message_update( maybe_enqueue_notifications_for_message_update(
user_profile_id=user_profile_id, user_profile_id=user_profile_id,
message_id=message_id, message_id=message_id,
stream_name=stream_name, private_message=(stream_name is None),
prior_mention_user_ids=prior_mention_user_ids,
mention_user_ids=mention_user_ids, mention_user_ids=mention_user_ids,
wildcard_mention_notify=wildcard_mention_notify, wildcard_mention_notify=wildcard_mention_notify,
presence_idle_user_ids=presence_idle_user_ids,
stream_push_user_ids=stream_push_user_ids, stream_push_user_ids=stream_push_user_ids,
stream_email_user_ids=stream_email_user_ids, stream_email_user_ids=stream_email_user_ids,
stream_name=stream_name,
online_push_user_ids=online_push_user_ids, online_push_user_ids=online_push_user_ids,
presence_idle_user_ids=presence_idle_user_ids,
prior_mention_user_ids=prior_mention_user_ids,
) )
for client in get_client_descriptors_for_user(user_profile_id): for client in get_client_descriptors_for_user(user_profile_id):
@@ -1159,17 +1160,16 @@ def process_message_update_event(
def maybe_enqueue_notifications_for_message_update( def maybe_enqueue_notifications_for_message_update(
user_profile_id: UserProfile, user_profile_id: UserProfile,
message_id: int, message_id: int,
stream_name: Optional[str], private_message: bool,
prior_mention_user_ids: Set[int],
mention_user_ids: Set[int], mention_user_ids: Set[int],
wildcard_mention_notify: bool, wildcard_mention_notify: bool,
presence_idle_user_ids: Set[int],
stream_push_user_ids: Set[int], stream_push_user_ids: Set[int],
stream_email_user_ids: Set[int], stream_email_user_ids: Set[int],
stream_name: Optional[str],
online_push_user_ids: Set[int], online_push_user_ids: Set[int],
presence_idle_user_ids: Set[int],
prior_mention_user_ids: Set[int],
) -> None: ) -> None:
private_message = stream_name is None
if private_message: if private_message:
# We don't do offline notifications for PMs, because # We don't do offline notifications for PMs, because
# we already notified the user of the original message # we already notified the user of the original message