paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

empty_feed_notice: Add support for empty string topic.

Browse Source 
Earlier, we were not showing `realm_empty_topic_display_name`
value in the empty_feed_notice.
This commit is contained in:
Prakhar Pratyush
2025-02-18 21:57:50 +05:30
committed by Tim Abbott
parent 82646c4d96
commit 22efac5a77
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
web/src/narrow_banner.ts
View File

@@ -82,8 +82,9 @@ function retrieve_search_query_data(): SearchData {
const stream_name = stream_data.get_valid_sub_by_id_string(stream_id).name; const stream_name = stream_data.get_valid_sub_by_id_string(stream_id).name;
search_string_result.stream_query = stream_name; search_string_result.stream_query = stream_name;
} }
if (topic) { if (topic !== undefined) {
search_string_result.topic_query = topic; search_string_result.topic_query = util.get_final_topic_display_name(topic);
search_string_result.is_empty_string_topic = topic === "";
} }
} }

1
web/src/narrow_error.ts
View File

@@ -10,6 +10,7 @@ export type SearchData = {
has_stop_word: boolean; has_stop_word: boolean;
stream_query?: string; stream_query?: string;
topic_query?: string; topic_query?: string;
is_empty_string_topic?: boolean;
}; };
export type NarrowBannerData = { export type NarrowBannerData = {

4
web/templates/empty_feed_notice.hbs
View File

@@ -7,8 +7,12 @@
<span>channel: {{search_data.stream_query}}</span> <span>channel: {{search_data.stream_query}}</span>
{{/if}} {{/if}}
{{#if search_data.topic_query}} {{#if search_data.topic_query}}
{{#if search_data.is_empty_string_topic}}
<span>topic: <span class="empty-topic-display">{{search_data.topic_query}}</span></span>
{{else}}
<span>topic: {{search_data.topic_query}}</span> <span>topic: {{search_data.topic_query}}</span>
{{/if}} {{/if}}
{{/if}}
{{#each search_data.query_words}} {{#each search_data.query_words}}
{{#if is_stop_word}} {{#if is_stop_word}}
<del>{{query_word}}</del> <del>{{query_word}}</del>