paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 16:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_settings: Fix stream row switching behavior.

Browse Source 
Add a rule to the switch_rows(event) function to avoid
switching stream row when pressing up/down key by checking
the current URL hash and the add_subscribers_pill focus state.
Add a utility function to hash_parser to help implement new
switch_rows behavior mentioned above.

Fixes #29690.
This commit is contained in:
PieterCK
2024-04-25 17:34:44 +07:00
committed by Tim Abbott
parent 480bceae98
commit 2457a8b655
3 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
web/tests/hash_util.test.js
View File

@@ -161,6 +161,23 @@ run_test("test_is_create_new_stream_narrow", () => {
assert.equal(hash_parser.is_create_new_stream_narrow(), false);
});
run_test("test_is_subscribers_section_opened_for_stream", () => {
window.location.hash = "#streams/1/Design/subscribers";
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), true);
window.location.hash = "#streams/99/.EC.A1.B0.EB.A6.AC.EB.B2.95.20.F0.9F.98.8E/subscribers";
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), true);
window.location.hash = "#streams/random/subscribers";
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), false);
window.location.hash = "#some/random/place/subscribers";
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), false);
window.location.hash = "#";
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), false);
});
run_test("test_parse_narrow", () => {
assert.deepEqual(hash_util.parse_narrow(["narrow", "stream", "99-frontend"]), [
{negated: false, operator: "stream", operand: "frontend"},