paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a message's position not offset() to detect if it's off the bottom of the page

Browse Source 
(imported from commit f7915c567b54ad5fd82daf137f89db566a1b417b)
This commit is contained in:
Leo Franchi
2014-03-07 13:41:25 -05:00
committed by Steve Howell
parent eda05d23bf
commit 246a5737e7
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/notifications_bar.js
View File

@@ -31,11 +31,7 @@ function hide() {
// If there's a custom message, or if the last message is off the bottom of the // If there's a custom message, or if the last message is off the bottom of the
// screen, then show the notifications bar. // screen, then show the notifications bar.
exports.update = function (num_unread) { exports.update = function (num_unread) {
var last_row = rows.last_visible(); if (!viewport.bottom_message_visible() && num_unread > 0) {
if (last_row
&& last_row.offset() !== null // otherwise the next line will error
&& viewport.is_below_visible_bottom(last_row.offset().top + last_row.height())
&& num_unread > 0) {
show(); show();
} else { } else {
hide(); hide();