paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

poll_widget: Convert votes from object to Map.

Browse Source 
Fixes implicity stringification of the user ID keys.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2020-02-03 15:34:01 -08:00
committed by Tim Abbott
parent 85620df34e
commit 252910202b
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/poll_widget.js
View File

@@ -44,8 +44,8 @@ exports.poll_data_holder = function (is_my_poll, question, options) {
const options = []; const options = [];
for (const [key, obj] of key_to_option) { for (const [key, obj] of key_to_option) {
const voters = _.keys(obj.votes); const voters = [...obj.votes.keys()];
const current_user_vote = _.contains(voters, String(me)); const current_user_vote = _.contains(voters, me);
options.push({ options.push({
option: obj.option, option: obj.option,
@@ -82,7 +82,7 @@ exports.poll_data_holder = function (is_my_poll, question, options) {
const idx = data.idx; const idx = data.idx;
const key = sender_id + ',' + idx; const key = sender_id + ',' + idx;
const option = data.option; const option = data.option;
const votes = {}; const votes = new Map();
key_to_option.set(key, { key_to_option.set(key, {
option: option, option: option,
@@ -119,7 +119,7 @@ exports.poll_data_holder = function (is_my_poll, question, options) {
let vote = 1; let vote = 1;
// toggle // toggle
if (key_to_option.get(key).votes[me]) { if (key_to_option.get(key).votes.get(me)) {
vote = -1; vote = -1;
} }
@@ -145,9 +145,9 @@ exports.poll_data_holder = function (is_my_poll, question, options) {
const votes = option.votes; const votes = option.votes;
if (vote === 1) { if (vote === 1) {
votes[sender_id] = 1; votes.set(sender_id, 1);
} else { } else {
delete votes[sender_id]; votes.delete(sender_id);
} }
}, },
}, },