paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 23:43:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_service_bot_system: Fix strict_optional errors.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-07-04 15:50:18 -07:00
committed by Tim Abbott
parent 2a0e5616f1
commit 26fe6be16a
4 changed files with 64 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
zerver/lib/test_classes.py
View File

@@ -341,8 +341,7 @@ class ZulipTestCase(TestCase):
def create_test_bot(self, short_name: str,
user_profile: UserProfile,
full_name: str='Foo Bot',
assert_json_error_msg: str=None,
**extras: Any) -> Optional[UserProfile]:
**extras: Any) -> UserProfile:
self.login_user(user_profile)
bot_info = {
'short_name': short_name,
@@ -350,14 +349,27 @@ class ZulipTestCase(TestCase):
}
bot_info.update(extras)
result = self.client_post("/json/bots", bot_info)
if assert_json_error_msg is not None:
self.assert_json_error(result, assert_json_error_msg)
return None
else:
self.assert_json_success(result)
bot_email = f'{short_name}-bot@zulip.testserver'
bot_profile = get_user(bot_email, user_profile.realm)
return bot_profile
self.assert_json_success(result)
bot_email = f'{short_name}-bot@zulip.testserver'
bot_profile = get_user(bot_email, user_profile.realm)
return bot_profile
def fail_to_create_test_bot(
self, short_name: str,
user_profile: UserProfile,
full_name: str='Foo Bot',
*,
assert_json_error_msg: str,
**extras: Any,
) -> None:
self.login_user(user_profile)
bot_info = {
'short_name': short_name,
'full_name': full_name,
}
bot_info.update(extras)
result = self.client_post("/json/bots", bot_info)
self.assert_json_error(result, assert_json_error_msg)
def login_with_return(self, email: str, password: Optional[str]=None,
**kwargs: Any) -> HttpResponse: