paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 02:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

node tests: Clean up dispatch tests.

Browse Source 
These are minor cleanups to make tests more
idempotent.
This commit is contained in:
Steve Howell
2021-03-10 13:30:51 +00:00
committed by Steve Howell
parent b13af16ad0
commit 26fed458e6
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend_tests/node_tests/dispatch.js
View File

@@ -105,6 +105,7 @@ function assert_same(actual, expected) {
} }
run_test("alert_words", (override) => { run_test("alert_words", (override) => {
alert_words.initialize({alert_words: []});
assert(!alert_words.has_alert_word("fire")); assert(!alert_words.has_alert_word("fire"));
assert(!alert_words.has_alert_word("lunch")); assert(!alert_words.has_alert_word("lunch"));
@@ -194,6 +195,7 @@ run_test("default_streams", (override) => {
}); });
run_test("hotspots", (override) => { run_test("hotspots", (override) => {
page_params.hotspots = [];
const event = event_fixtures.hotspots; const event = event_fixtures.hotspots;
override(hotspots, "load_new", noop); override(hotspots, "load_new", noop);
dispatch(event); dispatch(event);
@@ -467,6 +469,7 @@ run_test("realm_emoji", (override) => {
} }
// Make sure we start with nothing... // Make sure we start with nothing...
emoji.update_emojis([]);
assert.equal(emoji.get_realm_emoji_url("spain"), undefined); assert.equal(emoji.get_realm_emoji_url("spain"), undefined);
dispatch(event); dispatch(event);
@@ -568,6 +571,9 @@ run_test("submessage", (override) => {
// For subscriptions, see dispatch_subs.js // For subscriptions, see dispatch_subs.js
run_test("typing", (override) => { run_test("typing", (override) => {
// Simulate that we are not typing.
page_params.user_id = typing_person1.user_id + 1;
let event = event_fixtures.typing__start; let event = event_fixtures.typing__start;
{ {
const stub = make_stub(); const stub = make_stub();
@@ -588,9 +594,10 @@ run_test("typing", (override) => {
assert_same(args.event.sender.user_id, typing_person1.user_id); assert_same(args.event.sender.user_id, typing_person1.user_id);
} }
// Get line coverage--we ignore our own typing events.
page_params.user_id = typing_person1.user_id; page_params.user_id = typing_person1.user_id;
event = event_fixtures.typing__start; event = event_fixtures.typing__start;
dispatch(event); // get line coverage dispatch(event);
}); });
run_test("update_display_settings", (override) => { run_test("update_display_settings", (override) => {