paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

backends: Import googleapiclient lazily.

Browse Source 
This saves about 30-50ms in the startup time of a Zulip manage.py
command.
This commit is contained in:
Tim Abbott
2018-08-08 09:11:49 -07:00
parent e1662024d1
commit 271c7fbe65
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zproject/backends.py
View File

@@ -1,7 +1,6 @@
import logging import logging
from typing import Any, Dict, List, Set, Tuple, Optional from typing import Any, Dict, List, Set, Tuple, Optional
from apiclient.sample_tools import client as googleapiclient
from django_auth_ldap.backend import LDAPBackend, _LDAPUser from django_auth_ldap.backend import LDAPBackend, _LDAPUser
import django.contrib.auth import django.contrib.auth
from django.contrib.auth.backends import RemoteUserBackend from django.contrib.auth.backends import RemoteUserBackend
@@ -183,6 +182,10 @@ class GoogleMobileOauth2Backend(ZulipAuthMixin):
def authenticate(self, google_oauth2_token: str=None, realm: Optional[Realm]=None, def authenticate(self, google_oauth2_token: str=None, realm: Optional[Realm]=None,
return_data: Optional[Dict[str, Any]]=None) -> Optional[UserProfile]: return_data: Optional[Dict[str, Any]]=None) -> Optional[UserProfile]:
# We lazily import apiclient as part of optimizing the base
# import time for a Zulip management command, since it's only
# used in this one code path and takes 30-50ms to import.
from apiclient.sample_tools import client as googleapiclient
if realm is None: if realm is None:
return None return None
if return_data is None: if return_data is None: