paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 19:06:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

push_notifications: Bring file to 100% coverage.

Browse Source
This commit is contained in:
Umair Khan
2017-05-12 13:12:38 +05:00
committed by Tim Abbott
parent fa5c66c439
commit 286f9a40e7
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools/test-backend
View File

@@ -60,7 +60,6 @@ target_fully_covered = {path for target in [
'zerver/lib/message.py', 'zerver/lib/message.py',
'zerver/lib/narrow.py', 'zerver/lib/narrow.py',
'zerver/lib/notifications.py', 'zerver/lib/notifications.py',
'zerver/lib/push_notifications.py',
'zerver/lib/request.py', 'zerver/lib/request.py',
'zerver/lib/response.py', 'zerver/lib/response.py',
'zerver/lib/sessions.py', 'zerver/lib/sessions.py',

8
zerver/lib/push_notifications.py
View File

@@ -34,7 +34,7 @@ from functools import partial
if settings.ZILENCER_ENABLED: if settings.ZILENCER_ENABLED:
from zilencer.models import RemotePushDeviceToken from zilencer.models import RemotePushDeviceToken
else: else: # nocoverage -- Not convenient to add test for this.
from mock import Mock from mock import Mock
RemotePushDeviceToken = Mock() # type: ignore # https://github.com/JukkaL/mypy/issues/1188 RemotePushDeviceToken = Mock() # type: ignore # https://github.com/JukkaL/mypy/issues/1188
@@ -143,11 +143,11 @@ def get_connection(cert_file, key_file):
connection.gateway_server.register_response_listener(response_listener) connection.gateway_server.register_response_listener(response_listener)
return connection return connection
if settings.APNS_CERT_FILE is not None and os.path.exists(settings.APNS_CERT_FILE): if settings.APNS_CERT_FILE is not None and os.path.exists(settings.APNS_CERT_FILE): # nocoverage
connection = get_connection(settings.APNS_CERT_FILE, connection = get_connection(settings.APNS_CERT_FILE,
settings.APNS_KEY_FILE) settings.APNS_KEY_FILE)
if settings.DBX_APNS_CERT_FILE is not None and os.path.exists(settings.DBX_APNS_CERT_FILE): if settings.DBX_APNS_CERT_FILE is not None and os.path.exists(settings.DBX_APNS_CERT_FILE): # nocoverage
dbx_connection = get_connection(settings.DBX_APNS_CERT_FILE, dbx_connection = get_connection(settings.DBX_APNS_CERT_FILE,
settings.DBX_APNS_KEY_FILE) settings.DBX_APNS_KEY_FILE)
@@ -231,7 +231,7 @@ def check_apns_feedback():
logging.info("Finished checking feedback for stale tokens") logging.info("Finished checking feedback for stale tokens")
if settings.ANDROID_GCM_API_KEY: if settings.ANDROID_GCM_API_KEY: # nocoverage
gcm = GCM(settings.ANDROID_GCM_API_KEY) gcm = GCM(settings.ANDROID_GCM_API_KEY)
else: else:
gcm = None gcm = None