paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 20:41:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

buddy list: Relax count limit when doing searches.

Browse Source 
A recent change filtered out offline users from the buddy list
whenever the list size would otherwise exceed 600.

This commit reverts half that change--we can now show 600+ users
again, but only when searching.
This commit is contained in:
Steve Howell
2018-04-23 21:13:52 +00:00
committed by Tim Abbott
parent 127ac0df54
commit 2879a63bcc
2 changed files with 43 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
static/js/buddy_data.js
View File

@@ -11,7 +11,7 @@ var exports = {};
*/
var max_size_before_shrinking = 600;
exports.max_size_before_shrinking = 600;
var presence_descriptions = {
active: 'is active',
@@ -108,8 +108,18 @@ function user_is_recently_active(user_id) {
return level(presence.get_status(user_id)) <= 2;
}
function maybe_shrink_list(user_ids) {
if (user_ids.length <= max_size_before_shrinking) {
function maybe_shrink_list(user_ids, filter_text) {
if (user_ids.length <= exports.max_size_before_shrinking) {
return user_ids;
}
if (filter_text) {
// If the user types something, we want to show all
// users matching the text, even if they have not been
// online recently.
// For super common letters like "s", we may
// eventually want to filter down to only users that
// are in presence.get_user_ids().
return user_ids;
}
@@ -132,7 +142,7 @@ exports.get_filtered_and_sorted_user_ids = function (filter_text) {
user_ids = presence.get_user_ids();
}
user_ids = maybe_shrink_list(user_ids);
user_ids = maybe_shrink_list(user_ids, filter_text);
return exports.sort_users(user_ids);
};