paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 02:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list_tooltips: Avoid showing undefined.

Browse Source 
If the template_id of the message_control_button
is undefined, we do not render the tooltip at all.
This might happen, for example,
when a message is past its editable period and
the edit button is not displayed.
This commit is contained in:
Kislay Verma
2025-03-12 11:41:43 +05:30
committed by Tim Abbott
parent f0e15cff77
commit 28a277027b
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/message_list_tooltips.ts
View File

@@ -232,9 +232,14 @@ export function initialize(): void {
if (tippy_content !== undefined) { if (tippy_content !== undefined) {
instance.setContent(tippy_content); instance.setContent(tippy_content);
} else { } else {
const $template = $(`#${CSS.escape($elem.attr("data-tooltip-template-id")!)}`); const template_id = $elem.attr("data-tooltip-template-id");
if (template_id === undefined) {
return false;
}
const $template = $(`#${CSS.escape(template_id)}`);
instance.setContent(parse_html($template.html())); instance.setContent(parse_html($template.html()));
} }
return undefined;
}, },
onHidden(instance) { onHidden(instance) {
instance.destroy(); instance.destroy();