paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 02:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_group_popover: Show popover on all .messagebox user group mention.

Browse Source 
Show user group popover for scheduled messages overlay, compose box
preview, message edit preview, message edit history.
`.messagebox` was chosen as the selector since that was the nearest
parent class that was common for all of the above.

This commit won't work for drafts overlay since drafts has a direct
event listener which receives the event before our delegated event
listener.

This commit also adds an explicit `cursor: pointer` to
`user-group-mention`.
This commit is contained in:
Shubham Padia
2024-07-26 03:27:20 +00:00
committed by Tim Abbott
parent 2b3a41be58
commit 29809ea61b
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/user_group_popover.ts
View File

@@ -143,6 +143,13 @@ export function register_click_handlers(): void {
toggle_user_group_info_popover(this, undefined); toggle_user_group_info_popover(this, undefined);
}, },
); );
// Note: Message feeds and drafts have their own direct event listeners
// that run before this one and call stopPropagation.
$("body").on("click", ".messagebox .user-group-mention", function (this: HTMLElement, e) {
e.stopPropagation();
toggle_user_group_info_popover(this, undefined);
});
} }
function fetch_group_members(member_ids: number[]): PopoverGroupMember[] { function fetch_group_members(member_ids: number[]): PopoverGroupMember[] {

10
web/styles/rendered_markdown.css
View File

@@ -173,9 +173,6 @@
} }
.user-mention { .user-mention {
/* We have to explicitly mention this for compose box preview
where cursor is set to not-allowed */
cursor: pointer;
color: var(--color-text-other-mention); color: var(--color-text-other-mention);
background-color: var(--color-background-text-direct-mention); background-color: var(--color-background-text-direct-mention);
@@ -189,6 +186,13 @@
} }
} }
.user-mention,
.user-group-mention {
/* We have to explicitly mention this for compose box preview
where cursor is set to not-allowed */
cursor: pointer;
}
/* We show the same cursor as the parent element for `@all` /* We show the same cursor as the parent element for `@all`
mention */ mention */
.user-mention-all { .user-mention-all {