paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: Add a rule to avoid msgid as a Python variable name.

Browse Source 
This is for consistency with our usual patterns, see #12995.  We will
need a similar commit for JavaScript to complete #12995.
This commit is contained in:
okmanl
2019-08-14 23:05:44 -07:00
committed by Tim Abbott
parent dc191b0be4
commit 2a1305de9f
3 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/linter_lib/custom_check.py
View File

@@ -227,6 +227,10 @@ python_rules = RuleList(
'zerver/lib/',
'zerver/tests/',
'zerver/views/'])},
{'pattern': 'msgid|MSGID',
'exclude': set(['tools/check-capitalization',
'tools/i18n/tagmessages']),
'description': 'Avoid using "msgid" as a variable name; use "message_id" instead.'},
{'pattern': '^(?!#)@login_required',
'description': '@login_required is unsupported; use @zulip_login_required',
'good_lines': ['@zulip_login_required', '# foo @login_required'],